accounts/external, signer/core: clef support for 2930-type txs #22585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to use clef as a backend for signing 2930 type transcations.
However, there is a snag. The
ChainId
is implemented by both legacy and new type transactions, and for the old type, it's derived from thev
. But when we approve it, it's not yet signed, so a legacy tx looks like this:And that's not great. If we have a
types.Transaction
, we don't really know if theChainId
represents the "User wants to sign for X" or "This tx is signed for X". cc @fjl any ideas?