core/state/snapshot: fix panic on missing parent #22551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a snapshot on top of a parent, the parent may occasionally be missing (if there are many blocks imported whilst simultaneously mining a new block). In that case, the current code panics because the path that checks for missing parent already makes an interface conversion before
nil
check.The fix is to do the
nil
check first and only afterwards to cast to thesnapshot
interface.