Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: fix error handling for header test #22514

Merged
merged 1 commit into from
Mar 19, 2021
Merged

ethclient: fix error handling for header test #22514

merged 1 commit into from
Mar 19, 2021

Commits on Mar 17, 2021

  1. ethclient: fix error handling for header test 

    The wantErr field was disused, and the error
returned by ec.HeaderByNumber was not properly
tested.

This simplifies the error checking using
errors.Is and asserts that getting an expected
missing header returns ethereum.NotFound.

Also adds a nil check condition for header.Number
before using big.Int's Sign method.

Date: 2021-03-17 07:57:26-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    51236d5 View commit details
    Browse the repository at this point in the history