Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add ancient datadir flag to snapshot subcommands #22486

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

michael1011
Copy link
Contributor

@michael1011 michael1011 commented Mar 11, 2021

When syncing with an non-default ancient data directory, the snapshot sub-commands aren't usable because Geth can't open the database. This PR adds the missing --database.ancient flags to the snapshot sub-commands

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it, LGTM!

@karalabe karalabe added this to the 1.10.2 milestone Mar 12, 2021
@karalabe karalabe merged commit 6387c52 into ethereum:master Mar 12, 2021
@michael1011 michael1011 deleted the fix-snapshot-ancient branch March 12, 2021 10:38
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants