Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix dumpgenesis #22406

Merged
merged 1 commit into from
Mar 9, 2021
Merged

cmd: fix dumpgenesis #22406

merged 1 commit into from
Mar 9, 2021

Conversation

rjl493456442
Copy link
Member

DumpGenesis is implemented in PR #20191. However, the command can only dump out the mainnet(default) genesis.
This PR fixes this issue by adding more network id flags.

What's more, in theory, this command is expected to dump out the genesis from the custom datadir. But it's not implemented yet.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.10.2 milestone Mar 9, 2021
@karalabe karalabe merged commit 22082f9 into ethereum:master Mar 9, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants