Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: fix eth_chainId method #22243

Merged
merged 6 commits into from
Apr 6, 2021
Merged

internal/ethapi: fix eth_chainId method #22243

merged 6 commits into from
Apr 6, 2021

Commits on Jan 27, 2021

  1. eth: Fix ethereum API ChainID marshaling 

    Although the ChainID is represented as a *big.Int in the ChainConfig, it
was being marshaled as a uint64 by the PublicEthereumAPI. This leads to
discrepancies between the config and calls to the API when the ChainID
is bigger than math.MaxUint64.
    @piersy
    piersy committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    43af6a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. De-duplicate ChainID api method implementations 

    Use the implementation of ChainId from eth/api.go in
internal/ethapi/api.go and removed ChainId from eth/api.go.
    @piersy
    piersy committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    12094e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Update api.go

    @fjl
    fjl authored Mar 19, 2021
    Configuration menu
    Copy the full SHA
    b9f40c8 View commit details
    Browse the repository at this point in the history

  2. Update api.go

    @fjl
    fjl authored Mar 19, 2021
    Configuration menu
    Copy the full SHA
    85c8f76 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Merge branch 'master' into fix_chainid_marshaling

    @fjl
    fjl authored Apr 6, 2021
    Configuration menu
    Copy the full SHA
    72be4e9 View commit details
    Browse the repository at this point in the history

  2. Update api.go

    @fjl
    fjl authored Apr 6, 2021
    Configuration menu
    Copy the full SHA
    d4d0206 View commit details
    Browse the repository at this point in the history