Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-2718: Typed Transaction Envelope + EIP-2930 #21502

Merged
merged 83 commits into from
Feb 25, 2021
Merged

EIP-2718: Typed Transaction Envelope + EIP-2930 #21502

merged 83 commits into from
Feb 25, 2021

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Aug 29, 2020 •
edited
Loading

Hi all, I'm working on implementing EIP-2718: Typed Transaction Envelope. As of ACD 92 it is considered EFI. It is a dependency for the following:

Given the amount of code that this PR will eventually update, it would help me a lot to get some feedback earlier on to make sure this is headed in a good direction. Please let me know if there is a better way to request feedback.

@lightclient lightclient marked this pull request as draft August 30, 2020 00:22
@lightclient lightclient changed the title Implement EIP-2718 EIP-2718: Typed Transaction Envelope Sep 3, 2020
@lightclient
Copy link
Member Author

lightclient commented Sep 4, 2020 •
edited
Loading

I'm planning to update this to use the original Transaction struct + interface as txdata (had trouble encoding the interface version).

@holiman
Copy link
Contributor

holiman commented Sep 7, 2020

Thanks for starting to work on this. It's a bit hard to judge if the interfaces are 'right' without more concrete examples, so I was wondering if you'd also be interested in implementing the 2930 transaction type within the same PR?
Note, you wouldn't need to implement the actual handling of access lists, but use the concrete new transaction type to see if the abstraction model you have chosen is sufficient to accommodate it?

I was thinking of picking it up myself, but it seems like a bad idea for me to implement something that you've already gotten a good start on... ?

@holiman
Copy link
Contributor

holiman commented Sep 7, 2020

Regarding your concrete questions, I don't really have any good answers now, I think it will be easier to give feedback with more concrete types implemented.

@lightclient
Copy link
Member Author

lightclient commented Sep 7, 2020 •
edited
Loading

I was wondering if you'd also be interested in implementing the 2930 transaction type within the same PR?

Yep, I would be happy to.

fjl
fjl requested changes Sep 10, 2020
View reviewed changes
core/types/legacy_tx.go Outdated Show resolved Hide resolved
@lightclient lightclient force-pushed the impl-eip-2718 branch 2 times, most recently from 7666d19 to 1de464f Compare September 10, 2020 15:30
@lightclient
Copy link
Member Author

@holiman @fjl, do you prefer the tests for this PR to be written natively in geth, as part of retesteth, or both?

@holiman
Copy link
Contributor

holiman commented Sep 15, 2020

do you prefer the tests for this PR to be written natively in geth, as part of retesteth, or both?

We always want 'native' tests in the codebase. If there are other more high-level tests that's good too, but we don't want to rely on those only

lightclient
lightclient commented Sep 21, 2020
View reviewed changes
core/state_processor.go Outdated Show resolved Hide resolved
@lightclient lightclient force-pushed the impl-eip-2718 branch 5 times, most recently from aaea762 to 3651b77 Compare September 27, 2020 01:55
@lightclient
Copy link
Member Author

Hi @holiman, I implemented EIP-2930 using the EIP-2718 envelope. This PR is rebased against your EIP-2929 PR. For a simpler diff, I have a PR on my own repo against your branch.

@lightclient lightclient mentioned this pull request Oct 1, 2020
Closed
@holiman
Copy link
Contributor

holiman commented Oct 19, 2020

I rebased this on top of access_lists.
I think it'll be easier to review this once that one is merged

@gzliudan gzliudan mentioned this pull request Apr 22, 2024
Merged
18 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request May 14, 2024
@gzliudan
all: add support for EIP-2718, EIP-2930 transactions (ethereum#21502)
01e1728
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
d5cc4b9 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 7, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
cd1891a 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 8, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
2d9694f 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 9, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
c4cb45a 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
6e77551 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
a39a283 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
aca7a2b 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
435e3a0 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
fc7dcff 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
fe7919c 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
f6dbf3e 
…1502)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts: EIP-2718: Typed Transaction Envelope + EIP-2930 (ethereum#2…
7509329 
…1502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer left review comments

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@rakita rakita rakita left review comments

@karalabe karalabe karalabe left review comments

@ryanschneider ryanschneider ryanschneider left review comments

@fjl fjl fjl requested changes

@DGKSK8LIFE DGKSK8LIFE DGKSK8LIFE approved these changes

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
fork:berlin status:work-in-progress
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.