Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: add SetHeader method to Client #21392

Merged
merged 12 commits into from
Aug 3, 2020
Merged

rpc: add SetHeader method to Client #21392

merged 12 commits into from
Aug 3, 2020

Commits on Jul 30, 2020

  1. draft client set header

    @renaynay
    renaynay committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    ba40413 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. tests passing, headers added to conn, new http req instead of copy

    @renaynay
    renaynay committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    660f969 View commit details
    Browse the repository at this point in the history

  2. felixs suggestions, still need to remove ineffectual test

    @renaynay
    renaynay committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    2878c6b View commit details
    Browse the repository at this point in the history

  3. better test

    @renaynay
    renaynay committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    387bde5 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. rpc: rename httpConn.mux -> .mu 

    In go-ethereum, 'mu' and 'lock' are the canonical names
for lock-typed fields.
    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    9fdda31 View commit details
    Browse the repository at this point in the history

  2. rpc: improve TestClientSetHeader 

    This makes the test less reliant on client internals.
    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    3ef5db0 View commit details
    Browse the repository at this point in the history

  3. rpc: remove testHandler

    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    f020fe0 View commit details
    Browse the repository at this point in the history

  4. rpc: remove httpConn.req and improve setting of default headers 

    http.Header usually shouldn't be modified using map operations
because it performs canonicalization on the key strings.
    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    ce544aa View commit details
    Browse the repository at this point in the history

  5. rpc: restore URL parse check in DialHTTP*

    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    66a104d View commit details
    Browse the repository at this point in the history

  6. rpc: fix minor issue with header setting and add test for content-type

    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    e4bb090 View commit details
    Browse the repository at this point in the history

  7. rpc: improve error message for non-2xx responses with body

    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    ebd0374 View commit details
    Browse the repository at this point in the history

  8. rpc: fix header setting one last final time

    @fjl
    fjl committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    cac0bc7 View commit details
    Browse the repository at this point in the history