Fix posible nil exeption #21379
Merged
Fix posible nil exeption #21379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like CI fail is unrelated |
MariusVanDerWijden
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
LGTM
even though the aes can not produce errors on aes.NewGCM, the wrapping code in cipher might, see https://golang.org/src/crypto/cipher/gcm.go
3 tasks
recmo
pushed a commit
to recmo/go-ethereum
that referenced
this pull request
Feb 17, 2021
This was referenced Feb 24, 2021
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and Markdown Path correction + html fix