Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/devp2p: print enode:// URL in enrdump #21270

Merged
merged 2 commits into from
Aug 4, 2020
Merged

cmd/devp2p: print enode:// URL in enrdump #21270

merged 2 commits into from
Aug 4, 2020

Conversation

adamschmideg
Copy link
Contributor

@adamschmideg adamschmideg commented Jun 29, 2020 •
edited by holiman
Loading

Add the last line to what devp2p enrdump ... prints:

Node ID: 42a31d1a2ab3ad2cf79670255444926a333a3de4259e57d39a387b60b274b982
Record has sequence number 15 and 6 key/value pairs.
  "eth"       c7c68480cb8ad480
  "id"        "v4"
  "ip"        18.211.172.244
  "secp256k1" a10361e8a477bdb61e09fc10f43a0a9a139f72282d04ea8f8b4bf341694cc1abb26f
  "tcp"       30332
  "udp"       30332
URLv4: enode://[email protected]:30302

@holiman holiman requested a review from fjl June 30, 2020 08:40
@holiman
Copy link
Contributor

holiman commented Jun 30, 2020

@adamschmideg does it literally print enode://[email protected]:30302, with the ellipsis? Seems like a very bad UX to not print out the entire thing

@adamschmideg
Copy link
Contributor Author

No, no, it prints the full enode, the ellipsis is only here in the example. It was a stupid thing to do :)

@fjl fjl changed the title Print full enode url for enr cmd/devp2p: print enode:// URL in enrdump Jul 3, 2020
@fjl fjl merged commit e24e05d into ethereum:master Aug 4, 2020
@fjl fjl added this to the 1.9.19 milestone Aug 4, 2020
This was referenced Feb 24, 2021
Closed
Merged
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
@adamschmideg @fjl @enriquefynn
cmd/devp2p: print enode:// URL in enrdump (ethereum#21270)
67aca11 
Co-authored-by: Felix Lange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.19
Development

Successfully merging this pull request may close these issues.
3 participants
@adamschmideg @holiman @fjl