p2p/discv5: fix test on go 1.14 #20724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this only fail on Go 1.14? If you change the error for all Go releases, why does travis pass on 1.11, 1.12 and 1.13? |
|
This fails on go 1.14 because they tweaked the error message in the URL parser again to quote the input. On previous go releases, the error was |
Ah, that's the magic. |
tonyredondo
pushed a commit
to scope-demo/go-ethereum
that referenced
this pull request
Feb 27, 2020
* internal/ethapi: default to zero address for calls (ethereum#20702) This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <[email protected]> * les: separate peer into clientPeer and serverPeer (ethereum#19991) * les: separate peer into clientPeer and serverPeer * les: address comments * mobile: add CallOpts.SetFrom (ethereum#20721) This was missing because I forgot to wrap it when bind.CallOpts.From as added. * crypto/bn256: fix import line (ethereum#20723) * p2p/discv5: fix test on go 1.14 (ethereum#20724) Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: gary rong <[email protected]> Co-authored-by: Adam Schmideg <[email protected]>
kjx98
pushed a commit
to kjx98/go-ethereum
that referenced
this pull request
Mar 17, 2020
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
) * go.mod: update golang.org/x/crypto to fix a Go 1.14 race rejection Cherry-pick conflicts: go.mod go.sum * p2p/discv5: fix test on go 1.14 (ethereum#20724) Cherry-picked to celo-blockchain * travis, appveyor, build, Dockerfile: bump Go to 1.14.2 (ethereum#20913) * travis, appveyor, build, Dockerfile: bump Go to 1.14.2 * travis, appveyor: force GO111MODULE=on for every build Cherry-pick conflicts: .travis.yml appveyor.yml build/checksums.txt * Update CircleCI and dockerfiles to use Go 1.14 * Revert ios build CI config to work with Go 1.13 * Update golang download links to 1.14.12 Co-authored-by: Péter Szilágyi <[email protected]> Co-authored-by: Felix Lange <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]> Co-authored-by: Felix Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.