Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/filters: remove use of event.TypeMux for pending logs #20312

Merged
merged 9 commits into from
Dec 10, 2019
Merged

eth/filters: remove use of event.TypeMux for pending logs #20312

merged 9 commits into from
Dec 10, 2019

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Nov 18, 2019 •
edited
Loading

This fixes the following staticcheck warnings:

eth/filters/api.go:56:13: SA1019: event.TypeMux is deprecated: use Feed  (staticcheck)
	mux       *event.TypeMux
	           ^
eth/filters/filter.go:35:14: SA1019: event.TypeMux is deprecated: use Feed  (staticcheck)
	EventMux() *event.TypeMux
	            ^
eth/filters/filter_system.go:92:13: SA1019: event.TypeMux is deprecated: use Feed  (staticcheck)
	mux       *event.TypeMux
	           ^
internal/ethapi/backend.go:46:14: SA1019: event.TypeMux is deprecated: use Feed  (staticcheck)
	EventMux() *event.TypeMux
	            ^
accounts/abi/bind/backends/simulated.go:79:42: SA1019: event.TypeMux is deprecated: use Feed  (staticcheck)
		events:     filters.NewEventSystem(new(event.TypeMux), &filterBackend{database, blockchain}, false),
		                                       ^
accounts/abi/bind/backends/simulated.go:467:38: SA1019: event.TypeMux is deprecated: use Feed  (staticcheck)
func (fb *filterBackend) EventMux() *event.TypeMux { panic("not supported") }
                                     ^

karalabe
karalabe reviewed Nov 20, 2019
View reviewed changes
accounts/abi/bind/backends/simulated.go
<-quit
return nil
})
return nullSubscription()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really weird. Why do we have this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this because returning a nil subscription is not allowed. nullSubscription returns a subscription that never sends anything.

@fjl
Copy link
Contributor Author

fjl commented Nov 21, 2019

@karalabe PTAL

karalabe
karalabe approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.10 milestone Dec 10, 2019
@fjl fjl merged commit d90d1db into ethereum:master Dec 10, 2019
@benbaley benbaley mentioned this pull request Jan 14, 2021
Closed
@ricardolyn ricardolyn mentioned this pull request Feb 3, 2021
Merged
7 tasks
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
@fjl @enriquefynn
eth/filters: remove use of event.TypeMux for pending logs (ethereum#2…
0501e29 
…0312)
@chris-j-h chris-j-h mentioned this pull request Mar 26, 2021
Closed
@sudeepdino008 sudeepdino008 mentioned this pull request Mar 23, 2022
Merged
@gzliudan gzliudan mentioned this pull request Jul 10, 2024
Closed
20 tasks
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Jul 11, 2024
@JukLee0ira
eth/filters: remove use of event.TypeMux for pending logs (ethereum#2…
04628e3 
…0312)
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Jul 23, 2024
@JukLee0ira
eth/filters: remove use of event.TypeMux for pending logs (ethereum#2…
dc870ef 
…0312)
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Aug 3, 2024
@JukLee0ira
eth/filters: remove use of event.TypeMux for pending logs (ethereum#2…
acd53da 
…0312)
gzliudan pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 3, 2024
@JukLee0ira @gzliudan
eth/filters: remove use of event.TypeMux for pending logs (ethereum#2…
83782e5 
…0312)
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 23, 2024
@JukLee0ira @wanwiset25
eth/filters: remove use of event.TypeMux for pending logs (ethereum#2…
67d4f90 
…0312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.10
Development

Successfully merging this pull request may close these issues.
2 participants
@fjl @karalabe