accounts/abi/backends/simulated: add more API methods (#5) #20208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* backends: implement more of ethclient in sim * backends: add BlockByNumber to simulated backend * backends: make simulated progress function agree with syncprogress interface for client * backends: add more tests * backends: add more comments * backends: fix sim for index in tx and add tests
fjl
changed the title
|
@fjl Please let me know if I can provide any further details for this PR to make reviewing it easier |
|
@fjl @gballet @adamschmideg Is there's anything I can provide to help push this PR forward? Thanks! |
* backends: implement more of ethclient in sim * backends: add BlockByNumber to simulated backend * backends: make simulated progress function agree with syncprogress interface for client * backends: add more tests * backends: add more comments * backends: fix sim for index in tx and add tests
connorwstein
force-pushed
the
igitter-sim-improved
branch
from
3715e1b
to
974574b
Compare
|
@gitteri one thing you could do would be to fix the linter issue, please |
added 2 commits
November 27, 2019 08:54
|
@gballet just fixed it. Looks like the failure in ci is unrelated to this pr: |
|
@gballet just a friendly bump for this. Let me know if there's anyone else who can also help review this pr that I should reach out to |
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
…thereum#20208) * Add more functionality to the sim (ethereum#5) * backends: implement more of ethclient in sim * backends: add BlockByNumber to simulated backend * backends: make simulated progress function agree with syncprogress interface for client * backends: add more tests * backends: add more comments * backends: fix sim for index in tx and add tests * backends: add lock back to estimategas * backends: goimports * backends: go ci lint * Add more functionality to the sim (ethereum#5) * backends: implement more of ethclient in sim * backends: add BlockByNumber to simulated backend * backends: make simulated progress function agree with syncprogress interface for client * backends: add more tests * backends: add more comments * backends: fix sim for index in tx and add tests * backends: add lock back to estimategas * backends: goimports * backends: go ci lint * assert errs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolated automated integration tests were hard for us with the current backend simulator. In order to have a robust test suite I added methods to the backend simulator that have been extremely helpful for testing. Additionally, I added unit tests for almost all the methods of the backend simulator (but not the ones for the filter backend).
New methods added to the simulated backend:
BlockByHash
BlockByNumber
HeaderByHash
HeaderByNumber
TransactionCount
TransactionInBlock
SubscribeNewHead
The Simulated backend now implements the following interfaces:
ChainReader, ChainStateReader, ContractBackend, ContractCaller, ContractFilterer, ContractTransactor, DeployBackend, GasEstimator, GasPricer, LogFilterer, PendingContractCaller, TransactionReader, and TransactionSender