core: fix tx dedup return error count #20085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
txpool-api-fix
branch
from
8cf791f
to
fbef508
Compare
holiman
approved these changes
Sep 18, 2019
karalabe
force-pushed
the
txpool-api-fix
branch
from
fbef508
to
f40ff23
Compare
rjl493456442
approved these changes
Sep 18, 2019
20 tasks
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
May 13, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #20081.
The above mentioned PR moved transaction deduplication out of the global pool lock. Unfortunately, I didn't take care with the returned errors, losing a return value for every known transaction. This PR fixes the returned error slice to have a valid value for known transactions too.