common: fix #1818, secondary datadir paths to fall back to #1856
Conversation
Updated: Thu Oct 1 13:30:59 UTC 2015 |
|
Hey @0mkara, if you have the time, could you check if this fix solves the homedir issue for you on Fedora? Thanks! |
| return filepath.Join(dir, "Ethereum") | ||
| } else if runtime.GOOS == "windows" { | ||
| return filepath.Join(dir, "Ethereum") | ||
| } else { |
There was a problem hiding this comment.
I'm not sure about this. On Android this will probably be fine. On Fedora it is a bug and when it gets fixed the datadir might change. And each time the user starts geth in a different dir the datadir is different. This can get really confusing. Maybe its best on Fedora to exit the program and print a message informing the user that he needs to specify the datadir manually.
There was a problem hiding this comment.
Well, another option would be to drop the second block (the pwd one), and check in geth main that an empty data dir should return an error. I'm fine with that approach too. This is actually why I never implemented this, because I couldn't decide what the best course of action is.
There was a problem hiding this comment.
Consider using os.Getenv("HOME") as a fallback.
That should also work on Fedora in most cases.
|
Yes @karalabe this worked on fedora for me. |
karalabe
force-pushed
the
andorid-path-fix
branch
2 times, most recently
from
77ed191
to
74578ab
Compare
|
👍 |
common: fix #1818, secondary datadir paths to fall back to
|
👍 |
…merge_v1.10.16_v1.12.2 Merge develop to big merge v1.10.16 v1.12.2
This PR fixes an issue in Fedora and Android where the current user cannot be retrieved on certain platforms (Actually, the fix is more generic). If the user cannot be accessed, the default data dir uses a workspace in the current working folder. If that also cannot be retrieved, it defaults to an empty folder, leaving it to the user to sort it out manually via CLI flags (still better than crashing).