Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: include block hash from FilterQuery #17996

Merged
merged 1 commit into from
Nov 8, 2018
Merged

ethclient: include block hash from FilterQuery #17996

merged 1 commit into from
Nov 8, 2018

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Oct 28, 2018

#16734 introduced BlockHash to the FilterQuery struct.

However, the ethclient.go was not updated to include BlockHash in the actual rpc request.

@tamirms
ethclient: include block hash from FilterQuery
ba4b571 
ethereum#16734 introduced BlockHash to
the FilterQuery struct. However, the ethclient.go was not updated
to include BlockHash in the actual rpc request.
@tamirms
Copy link
Contributor Author

tamirms commented Oct 29, 2018

@fjl or @karalabe could you take a look? I believe you both have some commits to this package and would be able to review this PR. thanks!

@fjl fjl merged commit b16cc50 into ethereum:master Nov 8, 2018
@karalabe karalabe added this to the 1.8.18 milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.18
Development

Successfully merging this pull request may close these issues.
3 participants
@tamirms @fjl @karalabe