-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethdb: Add paused write stat #15663
ethdb: Add paused write stat #15663
Conversation
75d64da
to
8978fcb
Compare
@karalabe PTAL |
Sweet :) A few suggestions:
|
7164449
to
412f09b
Compare
Updated. I run go-ethereum with fast sync mode at a clear state and dump write delay information to a file. So i set the write delay number threshold at 200, and write delay duration threshold at 350 milliseconds. If the stats beyond the threshold, a warning log will been printed at user's console. |
ethdb/database.go
Outdated
var OpenFileLimit = 64 | ||
const ( | ||
writeDelayNThreshold = 250 | ||
writeDelayThreshold = 500 * 1000 * 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 500 * time.Millisecond
here.
412f09b
to
c3bb251
Compare
16fcb9b
to
f2d8d85
Compare
Superseded in #16499 |
Note: we need to wait this pr in goleveldb get merged and do the next :)
Implements #15347