-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geth -pricelimit not very useful after EIP1559 #23837
Comments
It's an interesting issue! I mark it as triage to discuss with team. |
The issue is: in TxPool, the value of Lines 624 to 627 in 03bc8b7
However, we apply a different check when selecting transactions for mining: Lines 547 to 549 in 03bc8b7
I think this issue could be resolved by making the check in |
The price limit is supposed to exclude transactions with too low fee amount. Before EIP-1559, it was sufficient to check the limit against the gas price of the transaction. After 1559, it is more complicated because the concept of 'transaction gas price' does not really exist. When mining, the price limit is used to exclude transactions below a certain effective fee amount. This change makes it apply the same check earlier, in tx validation. Transactions below the specified fee amount cannot enter the pool. Fixes ethereum#23837
The price limit is supposed to exclude transactions with too low fee amount. Before EIP-1559, it was sufficient to check the limit against the gas price of the transaction. After 1559, it is more complicated because the concept of 'transaction gas price' does not really exist. When mining, the price limit is used to exclude transactions below a certain effective fee amount. This change makes it apply the same check earlier, in tx validation. Transactions below the specified fee amount cannot enter the pool. Fixes #23837
…3855) The price limit is supposed to exclude transactions with too low fee amount. Before EIP-1559, it was sufficient to check the limit against the gas price of the transaction. After 1559, it is more complicated because the concept of 'transaction gas price' does not really exist. When mining, the price limit is used to exclude transactions below a certain effective fee amount. This change makes it apply the same check earlier, in tx validation. Transactions below the specified fee amount cannot enter the pool. Fixes ethereum#23837
Line 300 in cc87cbd
Line 424 in cc87cbd
|
may be we should using // Drop non-local transactions under our own minimal accepted gas price or tip.
if !local && tx.GasFeeCapIntCmp(pool.gasPrice) < 0 {
return ErrUnderpriced
} go-ethereum/core/types/transaction.go Lines 308 to 311 in 7f7877a
gasFeeCap reference MaxFeePerGas go-ethereum/core/types/transaction.go Lines 275 to 276 in 7f7877a
|
Best if we keep discussion in the new issue #24079 |
…3855) The price limit is supposed to exclude transactions with too low fee amount. Before EIP-1559, it was sufficient to check the limit against the gas price of the transaction. After 1559, it is more complicated because the concept of 'transaction gas price' does not really exist. When mining, the price limit is used to exclude transactions below a certain effective fee amount. This change makes it apply the same check earlier, in tx validation. Transactions below the specified fee amount cannot enter the pool. Fixes ethereum#23837
I'd like to raise a potential issue with the
geth -pricelimit
parameter and EIP1559.From my observations it looks like this parameter only checks the value of
MaxPriorityFeePerGas
instead of something more useful likeMaxFeePerGas
. I believe that the-pricelimit
is now fairly useless sinceMaxPriorityFeePerGas
is almost always around 1 to 3 Gwei even though the total tx gas price could easily be 100+ Gwei.Due to this behaviour I have set this parameter to 1 Gwei which causes the geth node to receive a huge amount of low gas pre-EIP1559 tx's that have been pending for months.
It is not in alignment with the way it works for pre-EIP1559 transactions.
The text was updated successfully, but these errors were encountered: