graphql: avoid greedy allocation (#27873)

Fixes a graphql-dos --------- Co-authored-by: Sina Mahmoodi <[email protected]> Co-authored-by: Sina Mahmoodi <[email protected]>
ethereum · Aug 8, 2023 · 0d772b9 · 0d772b9
1 parent 6d2bcb9
commit 0d772b9
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/graphql/graphql.go b/graphql/graphql.go
@@ -1250,7 +1250,7 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
 	if to < from {
 		return []*Block{}, nil
 	}
-	ret := make([]*Block, 0, to-from+1)
+	var ret []*Block
 	for i := from; i <= to; i++ {
 		numberOrHash := rpc.BlockNumberOrHashWithNumber(i)
 		block := &Block{
@@ -1268,6 +1268,9 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
 			break
 		}
 		ret = append(ret, block)
+		if err := ctx.Err(); err != nil {
+			return nil, err
+		}
 	}
 	return ret, nil
 }