-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EIP 7685 and 6110 #946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as the Python is concerned.
@@ -103,3 +116,79 @@ class Receipt: | |||
cumulative_gas_used: Uint | |||
bloom: Bloom | |||
logs: Tuple[Log, ...] | |||
|
|||
|
|||
def validate_requests(requests: Tuple[Bytes, ...]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also verify that the request root doesn't contain spurious requests with an unknown type. Otherwise the block builder could stuff arbitrary data into the requests list which is obviously bad.
Probably EIP 7685 should be updated to explicitly say that requests may not be included unless authorised by another EIP.
b9b13ef
to
7dfd46f
Compare
10ba0cd
to
47eb332
Compare
(closes #937 )
What was wrong?
The EIPs 7685 and 6110 were not implemented.
Related to Issue #937
How was it fixed?
Implement the EIPs for Prague
Cute Animal Picture