Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync fixes part 2: ethereum-types #1007

Merged
merged 37 commits into from
Sep 30, 2024
Merged

Sync fixes part 2: ethereum-types #1007

merged 37 commits into from
Sep 30, 2024

Conversation

SamWilsn
Copy link
Collaborator

What was wrong?

Sync would crash somewhere in Muir Glacier with a type error.

How was it fixed?

Removed int as a base class for Uint and friends

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn
Switch to ethereum-types (common)
0711146
@SamWilsn
Switch to ethereum-types (cancun)
0b32a39
@SamWilsn
Switch to ethereum-types (shanghai)
b13cfa8
@SamWilsn
Switch to ethereum-types (paris)
e15570b
@SamWilsn
Switch to ethereum-types (london)
a7d6395
@SamWilsn
Switch to ethereum-types (arrow_glacier,gray_glacier)
6f57983
@SamWilsn
Switch to ethereum-types (berlin)
af51556
@SamWilsn
Switch to ethereum-types (istanbul)
0b84b96
@SamWilsn
Switch to ethereum-types (muir_glacier)
ba405ba
@SamWilsn
Switch to ethereum-types (constantinople)
d6cf0d8
@SamWilsn
Switch to ethereum-types (byzantium)
a733404
@SamWilsn
Switch to ethereum-types (spurious_dragon)
01f6644
@SamWilsn
Switch to ethereum-types (tangerine_whistle)
9de33cd
@SamWilsn
Switch to ethereum-types (homestead)
c8bef93
@SamWilsn
Switch to ethereum-types (dao_fork)
7f09dea
@SamWilsn
Switch to ethereum-types (frontier)
e71ce7d
@SamWilsn
More transitioning to ethereum-types (common)
ec351f6
@SamWilsn
Use ethereum-types for fixed integers (cancun)
38b0770
@SamWilsn
Use ethereum-types for fixed integers (shanghai)
b847d53
@SamWilsn
Use ethereum-types for fixed integers (paris)
c659403
@SamWilsn
Use ethereum-types for fixed integers (london)
b070bf2
@SamWilsn
Use ethereum-types for fixed integers (arrow_glacier)
5f4ec32
@SamWilsn
Use ethereum-types for fixed integers (gray_glacier)
507505f
@SamWilsn
Use ethereum-types for fixed integers (berlin)
aa5dca2
@SamWilsn
Use ethereum-types for fixed integers (istanbul)
2085739
@SamWilsn
Use ethereum-types for fixed integers (muir_glacier)
d653ee9
@SamWilsn
Use ethereum-types for fixed integers (constantinople)
0a4cfaa
@SamWilsn
Use ethereum-types for fixed integers (byzantium)
d4230cb
@SamWilsn
Use ethereum-types for fixed integers (spurious_dragon)
025df81
@SamWilsn
Use ethereum-types for fixed integers (tangerine_whistle)
3dbfadd
petertdavies
petertdavies approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@petertdavies petertdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SamWilsn SamWilsn merged commit 9b95554 into ethereum:master Sep 30, 2024
5 checks passed
@SamWilsn SamWilsn deleted the sync-fixes branch September 30, 2024 13:56
@danceratopz danceratopz mentioned this pull request Sep 30, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertdavies petertdavies petertdavies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamWilsn @petertdavies