Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-7620: migrate "embedded container" tests #763

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 26, 2024

Migrate EOFTests/efValidation/EOF1_embedded_container_.json.

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Test cases type:test Type: Test labels Aug 26, 2024
@chfast chfast force-pushed the eof/migrate_embedded_container branch from ce57162 to b086cba Compare August 26, 2024 12:17
@chfast chfast force-pushed the eof/migrate_embedded_container branch from b086cba to 1eeacd5 Compare August 26, 2024 12:36
@chfast chfast added the type:refactor Type: Refactor label Aug 26, 2024
@chfast chfast force-pushed the eof/migrate_embedded_container branch from 1eeacd5 to 0bcbb6a Compare August 26, 2024 12:38
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments regarding the test IDs.

@chfast chfast force-pushed the eof/migrate_embedded_container branch from 0bcbb6a to 14d181d Compare August 27, 2024 15:29
@marioevz marioevz changed the title new(tests): migrate EOF "embedded container" tests new(tests): EOF - EIP-7620: migrate "embedded container" tests Aug 27, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit aee35f0 into ethereum:main Aug 27, 2024
6 checks passed
@marioevz marioevz deleted the eof/migrate_embedded_container branch August 27, 2024 18:56
chfast added a commit to ipsilon/tests that referenced this pull request Aug 27, 2024
- EOFTests/efValidation/EOF1_embedded_container_.json ethereum/execution-spec-tests#763
- EOFTests/efValidation/EOF1_section_order_.json ethereum/execution-spec-tests#741
winsvega pushed a commit to ethereum/tests that referenced this pull request Aug 31, 2024
- EOFTests/efValidation/EOF1_embedded_container_.json ethereum/execution-spec-tests#763
- EOFTests/efValidation/EOF1_section_order_.json ethereum/execution-spec-tests#741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:refactor Type: Refactor type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants