-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-7620: migrate "embedded container" tests #763
Merged
marioevz
merged 2 commits into
ethereum:main
from
ipsilon:eof/migrate_embedded_container
Aug 27, 2024
Merged
new(tests): EOF - EIP-7620: migrate "embedded container" tests #763
marioevz
merged 2 commits into
ethereum:main
from
ipsilon:eof/migrate_embedded_container
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
eof/migrate_embedded_container
branch
from
August 26, 2024 12:17
ce57162
to
b086cba
Compare
pdobacz
reviewed
Aug 26, 2024
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py
Outdated
Show resolved
Hide resolved
chfast
force-pushed
the
eof/migrate_embedded_container
branch
from
August 26, 2024 12:36
b086cba
to
1eeacd5
Compare
chfast
force-pushed
the
eof/migrate_embedded_container
branch
from
August 26, 2024 12:38
1eeacd5
to
0bcbb6a
Compare
marioevz
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments regarding the test IDs.
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py
Outdated
Show resolved
Hide resolved
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py
Outdated
Show resolved
Hide resolved
Migrate EOFTests/efValidation/EOF1_embedded_container_.json.
chfast
force-pushed
the
eof/migrate_embedded_container
branch
from
August 27, 2024 15:29
0bcbb6a
to
14d181d
Compare
marioevz
changed the title
new(tests): migrate EOF "embedded container" tests
new(tests): EOF - EIP-7620: migrate "embedded container" tests
Aug 27, 2024
marioevz
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
chfast
added a commit
to ipsilon/tests
that referenced
this pull request
Aug 27, 2024
- EOFTests/efValidation/EOF1_embedded_container_.json ethereum/execution-spec-tests#763 - EOFTests/efValidation/EOF1_section_order_.json ethereum/execution-spec-tests#741
winsvega
pushed a commit
to ethereum/tests
that referenced
this pull request
Aug 31, 2024
- EOFTests/efValidation/EOF1_embedded_container_.json ethereum/execution-spec-tests#763 - EOFTests/efValidation/EOF1_section_order_.json ethereum/execution-spec-tests#741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate EOFTests/efValidation/EOF1_embedded_container_.json.
π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.