new(tests): EOF - EIP-7069: Add tests #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
reviewed
Jul 30, 2024
marioevz
approved these changes
Jul 31, 2024
marioevz
changed the title
pdobacz
commented
Jul 31, 2024
| ase_ready_opcode = True | ||
| case _: | ||
| raise ValueError("Unexpected opcode ", target_opcode) | ||
| ase_ready_opcode = ( |
There was a problem hiding this comment.
Interestingly, if I left this expression as a (simplified) match-case statement, mypy complained about the type of target_opcode not being callable in the target_opcode(address=Op.CALLDATALOAD(0)) below. I've searched for the reason and also tried upgrading mypy to 1.11 - to no avail. Have I missed sth or maybe it's worth to produce a reproducible example and report?
spencer-tb
pushed a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Aug 8, 2024
* chore(tests): EIP-7069 - move tests from eip3540 dir * fix(tests): EIP-7069 - fix naming of extcall status codes * new(tests): EIP-7069 - add tests for EXT*CALL * chore(tests): EIP-7069 - drop the opcode-suffix pattern * chore(tests): EIP-7069 - drop unnecessary params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly inspired by ipsilon/eof#138 and evmone state_transition tests