Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-7480: Add tests for DATACOPY memory expansion #664

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Jul 3, 2024

🗒️ Description

Memory expansion tests for DATACOPY, minor refactor to MCOPY memory expansion test, made in order for them to match conventions.

I eyeballed the resulting JSONs from the MCOPY test and the divergence seems to be immaterial (different contract addresses).

The new test is a shameless rip-off the MCOPY mem expansion test. I'm not sure whether shared pieces should be refactored, please advise if so and how.

🔗 Related Issues

Working towards filling the gaps detected in ipsilon/eof#138

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@pdobacz pdobacz changed the title Datacopy Add tests for DATACOPY memory expansion Jul 3, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing the refactor to the mcopy file! :)

tests/cancun/eip5656_mcopy/test_mcopy_memory_expansion.py Outdated Show resolved Hide resolved
@marioevz marioevz changed the title Add tests for DATACOPY memory expansion new(tests): EOF - EIP-7480: Add tests for DATACOPY memory expansion Jul 8, 2024
@marioevz marioevz merged commit e2c2a24 into ethereum:main Jul 8, 2024
4 checks passed
@marioevz marioevz deleted the datacopy branch July 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants