-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EIP-2537: BLS12-381 Precompiles #499
Conversation
Compiled fixtures: These do not contain any other EIP for Prague, and therefore could fail on clients that do implement other EIPs in the same branch. |
8729572
to
432281c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I commeted a couple of tiny things.
As for extra tests, we could think about adding transition tests. Making sure the precompiles aren't accessible at Cancun but are at Prague. Or rather a single test that tries to use the precompiles correctly before the transition and after the transition.
tests/prague/eip2537_bls_12_381_precompiles/test_bls12_g1mul.py
Outdated
Show resolved
Hide resolved
Added in latest commit 👍 |
🗒️ Description
Tests for the BLS12-381 Precompiles added in EIP-2537.
At the moment this PR only contains vectors included in the EIP: https://eips.ethereum.org/assets/eip-2537/test-vectors
Updated to commit: ethereum/EIPs@57638c1
🔗 Related Issues
#498
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.