ci: Drop MSVC 32-bit support #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop build and support for MSVC 32-bit x86 architecture. "This platform is almost extinct". We continue to have some other 32-bit builds (GCC x86 and riscv32) to check pointer size and `size_t` correctness.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 143 143
Lines 16145 16145
=======================================
Hits 15224 15224
Misses 921 921
Flags with carried forward coverage won't be shown. Click here to find out more. |
battlmonstr
approved these changes
Aug 14, 2024
gumb0
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop build and support for MSVC 32-bit x86 architecture. "This platform is almost extinct".
We continue to have some other 32-bit builds (GCC x86 and riscv32) to check pointer size and
size_tcorrectness.