Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eof: Move type validation outside of header validation #1052

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Oct 14, 2024

This allows separate header and type validation and simplify the implementation of the former.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (bbd7e03) to head (d304085).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   94.23%   94.23%   -0.01%     
==========================================
  Files         155      155              
  Lines       16004    15997       -7     
==========================================
- Hits        15082    15075       -7     
  Misses        922      922              
Flag Coverage Δ
eof_execution_spec_tests 17.69% <100.00%> (-0.03%) ⬇️
ethereum_tests 27.46% <100.00%> (-0.03%) ⬇️
ethereum_tests_silkpre 19.31% <0.00%> (+<0.01%) ⬆️
execution_spec_tests 20.56% <0.00%> (+<0.01%) ⬆️
unittests 89.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.cpp 85.46% <100.00%> (-0.18%) ⬇️

Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Such refactor was considered earlier. I completely don't recall the reasons why this didn't go through back then. Looks all good now 🤷

@chfast
Copy link
Member Author

chfast commented Oct 15, 2024

I think #1034 was a prerequisite. I fuzzed these two PRs.

This allows separate header and type validation and simplify
the implementation of the former.
@chfast chfast merged commit b8e19f3 into master Oct 17, 2024
25 checks passed
@chfast chfast deleted the eof/validate_types branch October 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants