Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Export withdrawals to JSON state tests #1000

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 11, 2024

No description provided.

@chfast
Copy link
Member Author

chfast commented Sep 11, 2024

I implemented exporting "withdrawals" to JSON to fix round-trip JSON testing, but the test still don't pass.

@chfast chfast added good first issue Good for newcomers tests Testing infrastructure labels Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 29.76%. Comparing base (35b7475) to head (5ab9886).
Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
test/unittests/state_transition.cpp 0.00% 8 Missing ⚠️
test/unittests/state_transition_block_test.cpp 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (35b7475) and HEAD (5ab9886). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (35b7475) HEAD (5ab9886)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1000       +/-   ##
===========================================
- Coverage   93.84%   29.76%   -64.09%     
===========================================
  Files         146      146               
  Lines       15460    15468        +8     
===========================================
- Hits        14509     4604     -9905     
- Misses        951    10864     +9913     
Flag Coverage Δ
eof_execution_spec_tests 17.41% <0.00%> (-0.01%) ⬇️
ethereum_tests 27.79% <0.00%> (-0.02%) ⬇️
ethereum_tests_silkpre 19.47% <0.00%> (-0.02%) ⬇️
execution_spec_tests 18.92% <0.00%> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/state_transition_block_test.cpp 0.00% <0.00%> (-100.00%) ⬇️
test/unittests/state_transition.cpp 0.00% <0.00%> (-97.59%) ⬇️

... and 103 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests Testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant