Convert glossary link tags for Đ and DAG to lowercase
#7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken links from Table of Contents to definition. The links and hashes for all other items are lowercase and the generated urls are all lowercase. `#DAG` and `#D-with-stroke` were the only exceptions.
camerondurham
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 41m |
minimalsm
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Hey @camerondurham, nice catch and thanks for the PR 💪
We've just released our 2022 POAPs so remember to claim yours 🥳!
|
@all-contributors please add @camerondurham for bug, docs |
|
I've put up a pull request to add @camerondurham! 🎉 |
|
Woohoo, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Ethereum.org Contributor: Head on over to GitPOAP.io and connect your GitHub account to mint! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken links from Table of Contents to definition. The links and hashes for all other items are lowercase and the generated urls are all lowercase.
#DAGand#D-with-strokewere the only exceptions.Description
The generated links in the Glossary's table of contents does not directly link you to the definition.
#d-with-stroke, the actual link is#D-with-stroke)#dag, the actual link is#DAG)Example:
2. The link in the TOC is: https://ethereum.org/en/glossary/#d-with-stroke
3. The current direct link is: https://ethereum.org/en/glossary/#D-with-stroke
6. The link in the TOC is: https://ethereum.org/en/glossary/#dag
7. The current direct link is: https://ethereum.org/en/glossary/#DAG
Proposing to change the
#<LINK_NAME>to lowercase, matching all other short links in the glossary.Thanks!
Related Issue
Closes #7678