-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): add storybook-react-i18next addon #10234
feat(storybook): add storybook-react-i18next addon #10234
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
@pettinarip at the time of this comment, regarding the file conflicts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition @TylerAPfledderer
Would you mind if I add some translations to the existing stories in this PR?
@pettinarip made the suggested changes. All good with me! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @TylerAPfledderer I ended up removing the "buildLangs" since it was adding too much languages to the SB which I don't think we really need right now. For testing purposes, the baseLocales
are just enough and makes the build ligther. Later, if we consider that we need more langs we can add them.
@pettinarip I agree. All good with me! 😄 |
Description
Adds the storybook-react-i18next addon to the project storybook.
.env
main.js
file to TypeScriptRelated Issue
Discussion #9879