Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BIP32 HD account class. #24

Closed
pipermerriam opened this issue Jun 4, 2018 · 31 comments
Closed

Implement BIP32 HD account class. #24

pipermerriam opened this issue Jun 4, 2018 · 31 comments

Comments

@pipermerriam
Copy link
Member

What was wrong?

https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki

BIP32 specifies Hierarchical Deterministic Wallets. These are common ways to generate private keys.

How can it be fixed?

Implement a new account class HDAccount which exposes the same API (potentially via subclassing) as LocalAccount, with additional APIs for generating child accounts.

Test cases should include any public test vectors that are available as part of the spec.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.68 ETH (406.11 USD @ $597.22/ETH) attached to it.

@pipermerriam
Copy link
Member Author

@dilatebrave please open the pull request as soon as you have any work ready. We have a loose policy of showing your work before the bounty being reserved for you.

@dilatebrave
Copy link

@pipermerriam - ok, i will open the pr asap, currently i dont have my pc

@gitcoinbot
Copy link

@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@dilatebrave due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@dilatebrave due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vs77bb
Copy link

vs77bb commented Aug 21, 2018

Hi all - removed @dilatebrave from this issue, although he made good progress we didn't get this across. @pipermerriam are you still interested in having someone work on this?

It now shows 'Open' on the Gitcoin Issue Explorer.

@gitcoinbot
Copy link

gitcoinbot commented Aug 22, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 5 months, 1 week ago.
Please review their action plans below:

1) sea212 has started work.

Hello,

I have seen that the last worker was dismissed. Is this position still open?
I am master student of computer science who is writing a teaching book for cryptocurrencies. HD-Wallets were one chapter that I have intensely worked on and completed. Further I am experienced with python. Solving this task should be no problem.

Learn more on the Gitcoin Issue Details page.

@carver
Copy link
Contributor

carver commented Aug 22, 2018

Great, we welcome the attempt, @sea212 !

@gitcoinbot
Copy link

@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sea212
Copy link

sea212 commented Aug 29, 2018

work on halt until saturday (maybe friday evening). This weekend I'll report the progress.

@sea212
Copy link

sea212 commented Aug 31, 2018

Picked up work again.

@sea212
Copy link

sea212 commented Sep 1, 2018

Good progress is made. #31

@sea212
Copy link

sea212 commented Sep 5, 2018

Work completed. Please check my last post in the WIP #31 and the results. @pipermerriam @carver @vs77bb

@vs77bb
Copy link

vs77bb commented Sep 5, 2018

@sea212 great work, really appreciate the consistent updates! Thanks for tagging @pipermerriam / @carver, they'll have to do review / merge as the next step for the bounty 🙂

@gitcoinbot
Copy link

@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sea212
Copy link

sea212 commented Sep 10, 2018

Can you please give me any sign of life? I have completed this work 6 days ago and asked you to review it, no response. Now the bot begins to warn me. @pipermerriam @carver

@vs77bb
Copy link

vs77bb commented Sep 12, 2018

@sea212 Just snoozed the bot and pinged @carver on Gitter, expect something here soon. Apologies for silly @gitcoinbot 🙂

@sea212
Copy link

sea212 commented Sep 12, 2018

Thank you @vs77bb

@gitcoinbot
Copy link

@sea212 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • warning (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.68 ETH (143.12 USD @ $210.47/ETH) has been submitted by:

  1. @sea212

@vs77bb please take a look at the submitted work:


@pipermerriam
Copy link
Member Author

Hey @sea212 sorry for the radio silence. Life has been quite busy lately. Looking now.

@pipermerriam
Copy link
Member Author

@vs77bb you are clear to pay @sea212 the bounty.

@sea212 I deeply appreciate all of the work and good communication you put into this feature.

@sea212
Copy link

sea212 commented Sep 25, 2018

Hey @sea212 sorry for the radio silence. Life has been quite busy lately. Looking now.

Hey! No problem, I know how demanding it can get. Nevertheless, responding with just a tiny message like "I'll check it later, I'm very busy atm", if you have received my requests after all, would have greatly reduced my worries.

@sea212 I deeply appreciate all of the work and good communication you put into this feature.

Thank you, this means a lot to me!

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.68 ETH (150.03 USD @ $220.63/ETH) attached to this issue has been approved & issued to @sea212.

carver pushed a commit to carver/eth-account that referenced this issue Apr 25, 2019
@Oghma
Copy link

Oghma commented Sep 18, 2019

Hi! Any updates? When it will be merged in master?

@pipermerriam
Copy link
Member Author

cc @davesque

@davesque
Copy link
Contributor

Will try and get to this once some work is wrapped up on the blake2b project and a bit more progess has been made on the rust-vyper project.

@kclowes
Copy link
Collaborator

kclowes commented Mar 31, 2020

Closing with the merge of #87!

@kclowes kclowes closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants