Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci tests #800

Merged
merged 11 commits into from
Mar 19, 2019
Merged

ci tests #800

merged 11 commits into from
Mar 19, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Mar 18, 2019

Ports testing and spec build script from research repo. Note this PR is against master and will be backported into dev

Things:

  • build scrip in scripts/phase0
  • added Makefile to build executable spec and compile dependencies
  • dependencies and stubs added to utils/phase0. This includes minimal ssz, merklization, etc.
  • tests
    • ported sanity_check from research repo. no additional tests
    • two "marks" exist -- sanity and minimal_config -- for running quick tests locally. Run these limited marks via make test
    • CI runs full tests against minimal config and default config. If this gets out of hand, we can strip it down and just have releases have to pass the full tests.
    • note: these tests currently bypass the bug found in Block header signature issue #797 by considering the root of a block to be the hash_tree_root of the block with EMPTY_SIGNATURE. Will update these tests depending on which way Block header signature issue #797 goes.

Note, this will probably get a round or two of cleanups but wanted to get this up for merge now because its a blocker on all other PRs

@djrtwo djrtwo changed the base branch from dev to master March 18, 2019 20:15
@djrtwo djrtwo changed the title [WIP] ci ci tests Mar 18, 2019
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!! 🎉🎉🎉

Note, this will probably get a round or two of cleanups but wanted to get this up for merge now because its a blocker on all other PRs

Yep. I only did a quick review for now and approving. I will review (and probably refactor) it when it's in dev branch.

tests/phase0/helpers.py Outdated Show resolved Hide resolved
utils/phase0/state_transition.py Outdated Show resolved Hide resolved
tests/phase0/helpers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vbuterin vbuterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djrtwo djrtwo merged commit ab197d9 into master Mar 19, 2019
@djrtwo djrtwo deleted the ci branch March 19, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants