Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic fork versions and signature domains #738

Merged
merged 7 commits into from
Mar 12, 2019
Merged

Semantic fork versions and signature domains #738

merged 7 commits into from
Mar 12, 2019

Conversation

JustinDrake
Copy link
Collaborator

Address #706

hwwhww
hwwhww requested changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires BLS signature spec API updates and I think we agreed not changing BLS spec before it gets standardized?

@JustinDrake
Copy link
Collaborator Author

@hwwhww No changes to BLS spec required now 👍

hwwhww
hwwhww approved these changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

hwwhww
hwwhww reviewed Mar 9, 2019
View reviewed changes
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
specs/core/0_beacon-chain.md Outdated Show resolved Hide resolved
djrtwo added a commit to ethereum/research that referenced this pull request Mar 12, 2019
@djrtwo
handle semantic fork versions ethereum/consensus-specs#738
b29114f
@djrtwo djrtwo merged commit e843447 into dev Mar 12, 2019
@djrtwo djrtwo deleted the JustinDrake-patch-4 branch March 12, 2019 17:45
@terencechain terencechain mentioned this pull request Mar 15, 2019
Closed
@schroedingerscode schroedingerscode mentioned this pull request Mar 15, 2019
Closed
@hwwhww hwwhww mentioned this pull request Mar 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinDrake @djrtwo @hwwhww