Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor process_slashings #714

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Refactor process_slashings #714

merged 1 commit into from
Mar 3, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 3, 2019

Issue

The calculation for total_penalties can be extracted out of the for-loop.

Proposed solution

Simply move it before the loop.

@djrtwo djrtwo merged commit d293b12 into dev Mar 3, 2019
@djrtwo djrtwo deleted the hwwhww/refactor_process_slashing branch March 3, 2019 23:46
@akhila-raju akhila-raju mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo