Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "ready to exit" condition in update_validator_registry #705

Merged
merged 3 commits into from
Feb 28, 2019
Merged

Fix the "ready to exit" condition in update_validator_registry #705

merged 3 commits into from
Feb 28, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 28, 2019

  1. The ready to exit condition in update_validator_registry should use validator.exit_epoch to determine. Change to condition from
    validator.activation_epoch == FAR_FUTURE_EPOCH and validator.initiated_exit
    to
    validator.exit_epoch == FAR_FUTURE_EPOCH and validator.initiated_exit

  2. Refactor exit_validator.

@djrtwo djrtwo merged commit e5a2a6a into dev Feb 28, 2019
@djrtwo djrtwo deleted the hwwhww-patch-1 branch February 28, 2019 19:08
@akhila-raju akhila-raju mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo