Updated phase 1: shard block structure #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
reviewed
Feb 8, 2019
specs/core/1_shard-data-chains.md
Outdated
| for i in range(chunks-1, 0, -1): | ||
| o[i] = hash(o[i*2] + o[i*2+1]) | ||
| return o[1] | ||
| def get_proposal_committee(seed: Bytes32, |
There was a problem hiding this comment.
What will it be? persistent or proposal committee?
I think persistent is mildly better.
right now this doc uses both
There was a problem hiding this comment.
Let's do persistent.
(edited all the appearances to make it that way)
Co-Authored-By: vbuterin <[email protected]>
Co-Authored-By: vbuterin <[email protected]>
Co-Authored-By: vbuterin <[email protected]>
Co-Authored-By: vbuterin <[email protected]>
Co-Authored-By: vbuterin <[email protected]>
`hash32` -> `bytes32` ['uint384'] -> `bytes96`
hwwhww
reviewed
Feb 8, 2019
djrtwo
reviewed
Feb 9, 2019
Co-Authored-By: vbuterin <[email protected]>
Co-Authored-By: vbuterin <[email protected]>
Co-Authored-By: vbuterin <[email protected]>
|
Note: merge pending resolving handling exited validators within persistent committees. To ensure the 9 day lookahead on the set, we are leaning towards leaving them within, but having a method of fallback proposers when exited:
|
vbuterin
commented
Feb 10, 2019
vbuterin
commented
Feb 10, 2019
vbuterin
commented
Feb 10, 2019
|
Added a fix as three suggested changes to the code: https://github.com/ethereum/eth2.0-specs/pull/578/files |
djrtwo
approved these changes
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.