convert int_to_bytes to little endian #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
requested review from
hwwhww,
JustinDrake and
vbuterin
and removed request for
hwwhww
hwwhww
reviewed
Feb 3, 2019
specs/core/0_beacon-chain.md
Outdated
| # Read 3-bytes of `source` as a 24-bit big-endian integer. | ||
| sample_from_source = int.from_bytes(source[position:position + rand_bytes], 'big') | ||
| # Read 3-bytes of `source` as a 24-bit little-endian integer. | ||
| sample_from_source = int.from_bytes(source[position:position + rand_bytes], 'little') |
There was a problem hiding this comment.
Suggested change
| sample_from_source = int.from_bytes(source[position:position + rand_bytes], 'little') | |
| sample_from_source = int_to_bytes3(source[position:position + rand_bytes]) |
There was a problem hiding this comment.
We want to convert bytes-to-int, not int-to-bytes. int.from_bytes is correct, but definitely very pythonic
There was a problem hiding this comment.
Oooh, sorry for the misreading.
And I added bytes_to_int in #576.
There was a problem hiding this comment.
k. will wait on #576 merge and add bytes_to_int here
hwwhww
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #556