Fix a few nits dealing with updated makefile #4058
Conversation
jtraglia
commented
Dec 17, 2024
jtraglia
commented
- Hide output from forced eth2spec rebuild
- Call detect_errors after all generators are done
- Allow output to stderr to show up in console when testing
- Add note about printing to stderr
- Make check_toc private, as one should only use make lint
- Move _check_toc rule closer to lint rule
- Force rebuild eth2spec when running generators
- And do not rebuild pyspec now, no longer needed
* Hide output from forced eth2spec rebuild
* Call detect_errors after all generators are done
* Allow output to stderr to show up in console when testing
* Add note about printing to stderr
* Make check_toc private, as one should only use make lint
* Move _check_toc rule closer to lint rule
* Force rebuild eth2spec when running generators
* And do not rebuild pyspec now, no longer needed
| @@ -117,6 +117,7 @@ test: $(ETH2SPEC) pyspec | |||
| @mkdir -p $(TEST_REPORT_DIR) | |||
| @$(PYTHON_VENV) -m pytest \ | |||
| -n auto \ | |||
| --capture=no \ | |||
There was a problem hiding this comment.
FYI I usually use -s. It seems the same.
There was a problem hiding this comment.
Yeah these are the same. I prefer using the long-form options in scripts.
| @@ -85,7 +83,7 @@ $(ETH2SPEC): setup.py | $(VENV) | |||
|
|
|||
| # Force rebuild/install the eth2spec package. | |||
| eth2spec: | |||
| $(MAKE) --always-make $(ETH2SPEC) | |||
| @$(MAKE) --always-make $(ETH2SPEC) | |||
There was a problem hiding this comment.
sorry I didn't find it in the previous PR, but here, it seems eth2spec command doesn't trigger the rebuild (compile from markdown file to .py files)?
I think we need to trigger the make pyspec action: @$(PYTHON_VENV) setup.py pyspecdev here, no?
There was a problem hiding this comment.
These should be separate steps; the generators don't need it. Building eth2spec will compile the markdown files. These will exist in the build & venv dirs. And these are the files which are used by the generators. If I run make clean and make gen_all it will work without make pyspec.
But for make test we do need make pyspec. It adds these to the tests directory.
