-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PartialPendingWithdrawal field index
to validator_index
#4043
Merged
jtraglia
merged 5 commits into
ethereum:dev
from
lucassaldanha:rename-pending-withdrawal-field
Dec 9, 2024
Merged
Rename PartialPendingWithdrawal field index
to validator_index
#4043
jtraglia
merged 5 commits into
ethereum:dev
from
lucassaldanha:rename-pending-withdrawal-field
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally support this change. Thank you! Just a couple nits.
lucassaldanha
changed the title
Rename PartialPendintWithdrawal field
Rename PartialPendingWithdrawal field Dec 8, 2024
index
to validator_index
index
to validator_index
mkalinin
approved these changes
Dec 9, 2024
ppopth
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This PR changes
PendingPartialWithdrawal.index
toPendingPartialWithdrawal.validator_index
. This makes it more aligned withWithdrawal
and other places where we refer toValidatorIndex
asvalidator_index
.Justification
In Capella, we introduced
Withdrawal
with the following definition:And in Electra, we introduced
PendingPartialWithdrawal
as:The fact that we used
Withdrawal.validator_index
butPendingPartialWithdrawal.index
is confusing. And can be misleading given we haveWithdrawal.index
with a complete different meaning.