Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modcheck CI test #4034

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Fix modcheck CI test #4034

merged 4 commits into from
Dec 3, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Dec 3, 2024

The nightly test vector generator has been failing for a few days because the modcheck CI test had a bug (my fault). We forgot to check if there were errors in the log. This PR also fixes a generator oversight due to another recent change.

@jtraglia jtraglia added general:bug Something isn't working scope:CI/tests/pyspec labels Dec 3, 2024
@jtraglia jtraglia merged commit 0d5ad32 into ethereum:dev Dec 3, 2024
25 of 27 checks passed
@jtraglia jtraglia deleted the fix-modcheck branch December 3, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant