Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned here, it would be good to check that generator imports are correct. We can do this by running the generators with the new
--modcheck
flag. This is essentially a dry-run which returns before running any tests.Thanks to the
check_mod
function, this will throw an error if we forget to update a generator.check_mods
function for generators #3970I wanted to use
--collect-only
but it was broken. I added a "fix" but it didn't work because the KZG generators do things differently and would still execute. My solution was to replace--collect-only
.