Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gen-modcheck CI check #3986

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add gen-modcheck CI check #3986

merged 4 commits into from
Oct 29, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Oct 18, 2024

Mentioned here, it would be good to check that generator imports are correct. We can do this by running the generators with the new --modcheck flag. This is essentially a dry-run which returns before running any tests.

Thanks to the check_mod function, this will throw an error if we forget to update a generator.

I wanted to use --collect-only but it was broken. I added a "fix" but it didn't work because the KZG generators do things differently and would still execute. My solution was to replace --collect-only.

@jtraglia jtraglia changed the title Add gen-collect-only CI check Add gen-modcheck CI check Oct 18, 2024
@jtraglia jtraglia merged commit f392a22 into ethereum:dev Oct 29, 2024
26 checks passed
@jtraglia jtraglia deleted the gen-collect-only branch October 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants