Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject invalid DataColumnSidecar for zero blobs #3953

Merged
merged 12 commits into from
Oct 3, 2024
Merged

Reject invalid DataColumnSidecar for zero blobs #3953

merged 12 commits into from
Oct 3, 2024

Commits on Oct 2, 2024

  1. Reject invalid DataColumnSidecar for zero blobs

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    578407a View commit details
    Browse the repository at this point in the history

  2. Deepcopy sidecar before modifying it

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3f49e6c View commit details
    Browse the repository at this point in the history

  3. Use wrapper function which does the deepcopy

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4578b59 View commit details
    Browse the repository at this point in the history

  4. Create new verify_data_column_sidecar() function

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    df987b5 View commit details
    Browse the repository at this point in the history

  5. Add an extra blank line for consistency

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    09cc204 View commit details
    Browse the repository at this point in the history

  6. Move index check to top

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e02cbab View commit details
    Browse the repository at this point in the history

  7. Convert assert to return False

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3984bd3 View commit details
    Browse the repository at this point in the history

  8. Add missing semicolon

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3196487 View commit details
    Browse the repository at this point in the history

  9. Fix some nits

    @jtraglia
    jtraglia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2ceb0fd View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add new verification to is_data_available

    @jtraglia
    jtraglia committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3e80dc8 View commit details
    Browse the repository at this point in the history

  2. Put "and" at the beginning of the next line 

    Co-authored-by: Hsiao-Wei Wang <[email protected]>
    @jtraglia @hwwhww
    jtraglia and hwwhww authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    30f6aba View commit details
    Browse the repository at this point in the history

  3. Be more consistent with test names

    @jtraglia
    jtraglia committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    62c32da View commit details
    Browse the repository at this point in the history