Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient effective bal test and add a bal test #3947

Merged

Conversation

terencechain
Copy link
Contributor

This PR updated two things:

  • Fixed the test_insufficient_effective_balance test. Although the effective balance was set to be less than 32 ETH, the actual balance was also set incorrectly because the balance needs to exceed 32 ETH plus the withdrawal amount. This PR added the withdrawal amount to the validator's balance to ensure the effective balance is the only condition triggering the failure
  • Added a new test_insufficient_balance which has a sufficient effective balance but not enough actual balance, mimicking the above condition

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests are very much appreciated! Thank you!

@mkalinin mkalinin merged commit e8a013b into ethereum:dev Oct 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants