Fix insufficient effective bal test and add a bal test #3947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated two things:
test_insufficient_effective_balance
test. Although the effective balance was set to be less than 32 ETH, the actual balance was also set incorrectly because the balance needs to exceed 32 ETH plus the withdrawal amount. This PR added the withdrawal amount to the validator's balance to ensure the effective balance is the only condition triggering the failuretest_insufficient_balance
which has a sufficient effective balance but not enough actual balance, mimicking the above condition