Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cronjob for test vector generation #3922

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

parithosh
Copy link
Member

This PR will trigger the generate vectors job nightly at 2AM and upload the results as a job artifact. These artifacts can be consumed by anyone who relies on nightlies, with the knowledge that the tests haven't been verified or sanity checked (that only happens on releases).

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Just to be clear, is this 2am UTC time?

@parithosh
Copy link
Member Author

Good idea! Just to be clear, is this 2am UTC time?

Yeah exactly, Scheduled workflows always run on UTC time :D

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @parithosh!

Can every logged-in user access the artifacts? Or only the maintainers?

@parithosh
Copy link
Member Author

Thank you @parithosh!

Can every logged-in user access the artifacts? Or only the maintainers?

Every user can access the artifacts, even without logging in. So it should be easy for anyone to setup a CI to consume the result

@jtraglia jtraglia merged commit 7cacee6 into ethereum:dev Sep 16, 2024
26 checks passed
EchoAlice pushed a commit to EchoAlice/consensus-specs that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants