Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7594: PeerDAS explicit csc integer size #3897
EIP-7594: PeerDAS explicit csc integer size #3897
Changes from 6 commits
a59c7be
b69ff9b
7acf9e1
a0eabcf
68d1a6c
75f6953
cf8c838
652ca87
26d0200
cf68813
e05264b
6411967
edbb7f5
d0feb58
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to set
DATA_COLUMN_SIDECAR_SUBNET_COUNT
touint8
too, and then assertspec.config.DATA_COLUMN_SIDECAR_SUBNET_COUNT == uint8(spec.config.DATA_COLUMN_SIDECAR_SUBNET_COUNT)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we are only checking whether a client able read in the config.yaml value from the spec. Would it make more sense to assert that the csc value is uint8 in the enr value instead? This test case on its own probably makes little to no sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These unit tests only cover the helper functions. Pyspec tests don't cover the actual process where the client sets the ENR values.
We have an
assert custody_subnet_count <= DATA_COLUMN_SIDECAR_SUBNET_COUNT
inget_custody_columns
that capped the maximum value ofcustody_subnet_count
.