-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving requests out of execution_payload into beacon_block.body #3875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the requests from the payload as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a reasonable change!
and I agree w/ the line of thinking that got us here around pruning payloads
left two questions that I think block merge (unless im missing something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Original description from #3856
The original proposal for a
ExecutionPayloadEnvelope
has been surpassed by moving the requests out of theExecution Payload
into a new containerExecutionClientRequests
, a new field in theBeaconBlockBody
. This approach has a simpler design and maintains the gindex of the Execution Payload stable.Changes
ValidatorRequests
requests: ValidatorRequests
block.body.requests
TODO
process_withdrawals