Encode zero-length hex-strings with quotes #3754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running through the reference tests, I noticed that zero-length hex-strings are encoded without quotation marks. For example, in this test case which has a zero-length extra data field:
https://media.githubusercontent.com/media/ethereum/consensus-spec-tests/master/tests/mainnet/electra/ssz_static/ExecutionPayloadHeader/ssz_random/case_1/value.yaml
In other yaml files, this has quotation marks:
My solution was to wrap the yaml string representer method with a special case for hex-strings.