Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validate_blobs_sidecar a gossip condition #3108

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Make validate_blobs_sidecar a gossip condition #3108

merged 1 commit into from
Nov 17, 2022

Conversation

realbigsean
Copy link
Contributor

Discussion here #3103

Adds validate_blobs_sidecar as a gossip condition to ensure blobs won't be propagated if commitments in blocks don't match blobs.

@tbenr
Copy link
Contributor

tbenr commented Nov 17, 2022

I had some comments about gossip conditions here #3109

@hwwhww hwwhww added Deneb was called: eip-4844 scope:networking labels Nov 17, 2022
djrtwo
djrtwo approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@djrtwo djrtwo merged commit 30e9758 into ethereum:dev Nov 17, 2022
@mkalinin mkalinin mentioned this pull request Oct 31, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844 scope:networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realbigsean @tbenr @djrtwo @hwwhww