Add LightClientBootstrap
#2935
Merged
Add LightClientBootstrap
#2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new `LightClientBootstrap` structure to allow setting up a `LightClientStore` with the initial sync committee and block header from a user-configured trusted block root. This leads to new cases where the `LightClientStore` is only aware of the current but not the next sync committee. As a side effect of these new cases, the store's `finalized_header` may now advance into the next sync committee period before a corresponding `LightClientUpdate` with the new sync committee is obtained, improving responsiveness. Note that so far, `LightClientUpdate.attested_header.slot` needed to be newer than `LightClientStore.finalized_header.slot`. However, it is now necessary to also consider certain older updates to try and backfill the `next_sync_committee`. The `is_better_update` helper is also updated to improve `best_valid_update` tracking.
hwwhww
reviewed
Jul 13, 2022
There was a problem hiding this comment.
Having a bootstrap looks reasonable to me.
/cc @dapplion and @wemeetagain, you may be interested in this.
Co-authored-by: Hsiao-Wei Wang <[email protected]>
wemeetagain
approved these changes
Jul 13, 2022
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
LightClientBootstrapstructure to allow setting up aLightClientStorewith the initial sync committee and block header froma user-configured trusted block root.
This leads to new cases where the
LightClientStoreis only aware ofthe current but not the next sync committee. As a side effect of these
new cases, the store's
finalized_headermay now advance into the nextsync committee period before a corresponding
LightClientUpdatewiththe new sync committee is obtained, improving responsiveness.
Note that so far,
LightClientUpdate.attested_header.slotneeded to benewer than
LightClientStore.finalized_header.slot. However, it is nownecessary to also consider certain older updates to try and backfill the
next_sync_committee. Theis_better_updatehelper is also updated toimprove
best_valid_updatetracking.