Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing redundant next_sync_committee #2927

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Allow passing redundant next_sync_committee #2927

merged 1 commit into from
Jun 30, 2022

Conversation

etan-status
Copy link
Contributor

The producer of LightClientUpdate structures usually does not know how
far the LightClientStore on the client side has advanced. Updates are
currently rejected when including a redundant next_sync_committee not
advancing the LightClientStore. Behaviour is changed to allow this.

The producer of `LightClientUpdate` structures usually does not know how
far the `LightClientStore` on the client side has advanced. Updates are
currently rejected when including a redundant `next_sync_committee` not
advancing the `LightClientStore`. Behaviour is changed to allow this.
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

I like the symmetry of is_finality_update and is_sync_committee_update helpers!

@hwwhww hwwhww merged commit abcacca into ethereum:dev Jun 30, 2022
@etan-status etan-status deleted the lc-redundantnext branch June 30, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants